Add Semigroup (Predicate a) instance #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
requested changes
Jan 7, 2018
| @@ -310,9 +310,18 @@ newtype Predicate a = Predicate { getPredicate :: a -> Bool } | |||
| instance Contravariant Predicate where | |||
| contramap f g = Predicate $ getPredicate g . f | |||
|
|
|||
| #if defined(MIN_VERSION_semigroups) || __GLASGOW_HASKELL__ >= 711 | |||
There was a problem hiding this comment.
Use MIN_VERSION_base(4,9,0) instead of __GLASGOW_HASKELL__ >= 711.
| instance Monoid (Predicate a) where | ||
| mempty = Predicate $ const True | ||
| #if defined(MIN_VERSION_semigroups) || __GLASGOW_HASKELL__ >= 711 |
|
I copied the CPP conditional from other parts of the file, should I change them all into MIN_VERSION_base? Probably `tagged`&`Proxy` too?
…Sent from my iPhone
On 7 Jan 2018, at 22.40, Ryan Scott ***@***.***> wrote:
@RyanGlScott requested changes on this pull request.
LGTM besides one quibble about CPP usage.
In src/Data/Functor/Contravariant.hs:
> @@ -310,9 +310,18 @@ newtype Predicate a = Predicate { getPredicate :: a -> Bool }
instance Contravariant Predicate where
contramap f g = Predicate $ getPredicate g . f
+#if defined(MIN_VERSION_semigroups) || __GLASGOW_HASKELL__ >= 711
Use MIN_VERSION_base(4,9,0) instead of __GLASGOW_HASKELL__ >= 711.
In src/Data/Functor/Contravariant.hs:
> instance Monoid (Predicate a) where
mempty = Predicate $ const True
+#if defined(MIN_VERSION_semigroups) || __GLASGOW_HASKELL__ >= 711
Same here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Ah, fair enough. I (personally) believe we should eschew this use of |
27 tasks
|
Yes, let's use Let's merge this, and do refactoring later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38